Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks that heap size is a multiple of 4 KiB #110

Open
axel-h opened this issue Jun 7, 2022 · 0 comments
Open

Add checks that heap size is a multiple of 4 KiB #110

axel-h opened this issue Jun 7, 2022 · 0 comments

Comments

@axel-h
Copy link
Member

axel-h commented Jun 7, 2022

With from seL4/seL4_libs#63 (related also #109) the heap size must be a multiple of 4 KiB. We should try check this at compile time to avoid runtime errors like seL4/camkes-vm#28 happening then. Also update the CMake comment at CAMKES_DEFAULT_HEAP_SIZE to mention at least, that certain alignment might be a runtime library requirement.
If we break compilation, we also force the user to make a proper choice - might be better any trying fix the value. The memory management lib's startup code should also do a runtime check at startup. It might reduce the available heap in debug and release builds then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant