ringbuffer: add "has_data" helper function #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
reviewed
Oct 24, 2022
chrisguikema
force-pushed
the
ringbuffer_helpers
branch
2 times, most recently
from
7084511 to
96170d3
Compare
axel-h
approved these changes
Oct 26, 2022
|
@lsf37 can this be merged? |
|
I think so, but I'm not really across the ringbuffer implementation. @kent-mcleod ? |
Signed-off-by: Chris Guikema <[email protected]>
The ringbuffers are opaque, so the only way to check if a buffer has data is to add this simple helper function. Signed-off-by: Chris Guikema <[email protected]>
chrisguikema
force-pushed
the
ringbuffer_helpers
branch
from
96170d3 to
b0f4e86
Compare
Yea, it looks a bit too domain specific to justify having it as its own library... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ringbuffers are opaque, so the only way to check if a buffer has data is to add this simple helper function.