From 17e9c664cf4ff46e052fd3cc7470a1d06fbb519c Mon Sep 17 00:00:00 2001 From: Evan Sosenko Date: Wed, 4 Oct 2023 20:33:15 -0700 Subject: [PATCH] Remove TODOs (moved to issues) --- generate-routes.ts | 2 -- src/lib/seam/connect/client-options.ts | 6 ------ src/lib/seam/connect/seam-http.ts | 7 ------- 3 files changed, 15 deletions(-) diff --git a/generate-routes.ts b/generate-routes.ts index fb17e600..7d2724cb 100644 --- a/generate-routes.ts +++ b/generate-routes.ts @@ -53,8 +53,6 @@ const ignoredEndpointPaths = [ '/noise_sensors/simulate/trigger_noise_threshold', ] as const -// TODO: some endpoint's arguments (like list) are optional and should allow undefined - const endpointResources: Partial< Record< keyof typeof openapi.paths, diff --git a/src/lib/seam/connect/client-options.ts b/src/lib/seam/connect/client-options.ts index b692de7c..064577db 100644 --- a/src/lib/seam/connect/client-options.ts +++ b/src/lib/seam/connect/client-options.ts @@ -89,9 +89,3 @@ export class SeamHttpInvalidOptionsError extends Error { Error.captureStackTrace(this, this.constructor) } } - -// TODO: withSessionToken { sessionToken } or withMultiWorkspaceApiKey { apiKey }? -// export interface SeamHttpOptionsWithSessionToken extends SeamHttpCommonOptions { -// workspaceId: string -// apiKey: string -// } diff --git a/src/lib/seam/connect/seam-http.ts b/src/lib/seam/connect/seam-http.ts index 4e34ab4b..0dd84f23 100644 --- a/src/lib/seam/connect/seam-http.ts +++ b/src/lib/seam/connect/seam-http.ts @@ -127,10 +127,3 @@ export class SeamHttp { return SeamHttpWorkspaces.fromClient(this.client) } } - -// TODO -// static fromPublishableKey and deprecate getClientSessionToken - -// TODO: Should we keep makeRequest? -// Better to implement error handling and wrapping in an error handler. -// makeRequest