Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically determine endpointResources #6

Closed
razor-x opened this issue Sep 29, 2023 · 0 comments · Fixed by #87
Closed

Dynamically determine endpointResources #6

razor-x opened this issue Sep 29, 2023 · 0 comments · Fixed by #87
Assignees
Labels

Comments

@razor-x
Copy link
Contributor

razor-x commented Sep 29, 2023

Instead of using this: https://github.com/seamapi/javascript-http/blob/main/generate-routes.ts#L76
Use x-fern-sdk-return-value

Currently this exists in the openapi metadata as x-fern-sdk-return-value. This should instead be normalized to x-response-key to match the SDK (It is not a "fern thing" it's a Seam API thing):

readonly responseKey: TResponseKey

Fixing the key name is out of scope of this issue, but the value should be isolated to a constant, like

const openapiResponseKeyProp = 'x-fern-sdk-return-value'
@stale stale bot added the wontfix This will not be worked on label Oct 20, 2023
@razor-x razor-x removed the wontfix This will not be worked on label Oct 24, 2023
@seamapi seamapi deleted a comment from stale bot Apr 4, 2024
@razor-x razor-x added the codegen label Apr 4, 2024
@razor-x razor-x changed the title Remove endpointResources Dynamically determine endpointResources Apr 4, 2024
@andrii-balitskyi andrii-balitskyi self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants