Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated H3N2 reference to A/Perth/16/2009. #13

Closed
wants to merge 4 commits into from
Closed

Conversation

cassiawag
Copy link

@cassiawag cassiawag commented Jul 10, 2019

This commit should address #9 & #10. I swapped out all reference genomes for H3N2 for A/Perth/16/2009 segments, and I also updated the script create_ref_genome.py to add header information for reference_{lineage}_genome.gb.

@cassiawag cassiawag requested a review from trvrb July 10, 2019 17:35
@trvrb
Copy link
Member

trvrb commented Jul 10, 2019

@cassiawag: Thank you! Can you rebase these onto two separate PRs? Best practice is to have PRs be issue-specific.

@cassiawag
Copy link
Author

cassiawag commented Jul 10, 2019

Done! This PR now only updates the reference sequences in the config folder; should fix #10
@trvrb

@cassiawag
Copy link
Author

In Snakefile, just updated def reference_strain(wildcards): to specify A/Perth/16/2009 for H3N2.

@trvrb
Copy link
Member

trvrb commented Jul 14, 2019

@cassiawag: Thanks for putting in this PR. I now believe that A/Beijing/32/1992 is working well as a reference strain. I realize now moving to A/Perth/16/2009 will require updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants