[codegen]: Remove nullable types from weakly typed arrays

seclerp · Jul 7, 2024 · 88624ff · 88624ff
1 parent e8aedda
commit 88624ff
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/src/ChromeProtocol.Domains/Generated/DOM.cs b/src/ChromeProtocol.Domains/Generated/DOM.cs
@@ -217,7 +217,7 @@ public record RGBAType(
     /// <summary>An array of quad vertices, x immediately followed by y for each point, points clock-wise.</summary>
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record QuadType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }

diff --git a/src/ChromeProtocol.Domains/Generated/DOMSnapshot.cs b/src/ChromeProtocol.Domains/Generated/DOMSnapshot.cs
@@ -192,7 +192,7 @@ int Value
     /// <summary>Index of the string in the strings table.</summary>
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record ArrayOfStringsType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }
@@ -221,7 +221,7 @@ System.Collections.Generic.IReadOnlyList<int> Value
     }
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record RectangleType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }

diff --git a/src/ChromeProtocol.Domains/Generated/DOMStorage.cs b/src/ChromeProtocol.Domains/Generated/DOMStorage.cs
@@ -29,7 +29,7 @@ public record StorageIdType(
     /// <summary>DOM Storage item.</summary>
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record ItemType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }

diff --git a/src/ChromeProtocol.Domains/Generated/LayerTree.cs b/src/ChromeProtocol.Domains/Generated/LayerTree.cs
@@ -120,7 +120,7 @@ public record LayerType(
     /// <summary>Array of timings, one per paint step.</summary>
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record PaintProfileType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }

diff --git a/src/ChromeProtocol.Domains/Generated/Target.cs b/src/ChromeProtocol.Domains/Generated/Target.cs
@@ -73,7 +73,7 @@ public record FilterEntryType(
     /// </summary>
     [Newtonsoft.Json.JsonConverter(typeof(ChromeProtocol.Core.ArrayTypeConverter))]
     public record TargetFilterType(
-      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken?> Items
+      System.Collections.Generic.IReadOnlyCollection<Newtonsoft.Json.Linq.JToken> Items
     ) : ChromeProtocol.Core.IArrayType
     {
     }

diff --git a/src/ChromeProtocol.Tools/CodeGeneration/Pipeline/Steps/GenerateCsharpStep.cs b/src/ChromeProtocol.Tools/CodeGeneration/Pipeline/Steps/GenerateCsharpStep.cs
@@ -104,7 +104,7 @@ private static CsharpClassDeclBuilder GenerateType(ValidatedType type, Validated
 
       case { Kind: TypeKind.Array }:
         var itemsType = CsharpTypeInfo.FromGenericType("System.Collections.Generic", "IReadOnlyCollection",
-          CsharpTypeInfo.MakeNullable(CsharpTypeInfo.FromTypeName("Newtonsoft.Json.Linq", "JToken")));
+          CsharpTypeInfo.FromTypeName("Newtonsoft.Json.Linq", "JToken"));
         return classBuilder.Record(CsharpNameResolver.Resolve(type.Id, ItemKind.TypeName, classBuilder.Node.Name),
           recordBuilder => recordBuilder.Modifiers("public")
             .Attribute(CsharpTypeInfo.FromTypeName("Newtonsoft.Json", nameof(JsonConverter)),