Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix file path ref in import statement #45

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: fix file path ref in import statement #45

merged 1 commit into from
Nov 9, 2023

Conversation

ankit-flnc
Copy link
Contributor

Description:
when a typescript project with sats-connect as a dependency is being built by tsc getting below error

node_modules/sats-connect/dist/capabilities/types.d.ts:1:33 - error TS2307: Cannot find module 'src/provider' or its corresponding type declarations.

1 import type { Capability } from 'src/provider';
                                  ~~~~~~~~~~~~~~


Found 1 error in node_modules/sats-connect/dist/capabilities/types.d.ts:1

Changes:

  • fix import statement file path format.

@ankit-flnc
Copy link
Contributor Author

@yknl please review

victorkirov
victorkirov approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@victorkirov victorkirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙌

@yknl yknl merged commit ea7146c into secretkeylabs:develop Nov 9, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorkirov victorkirov victorkirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankit-flnc @victorkirov @yknl