From 7646a3c2787d5103b6aadd29e1fbaf4b1bfc2d99 Mon Sep 17 00:00:00 2001 From: noopur Date: Fri, 8 Nov 2024 08:11:13 +0000 Subject: [PATCH] Skip the buggy models for now Signed-off-by: noopur --- .github/workflows/task_runner_e2e.yml | 6 +++++- tests/openfl_e2e/test_suites/task_runner_tests.py | 3 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/task_runner_e2e.yml b/.github/workflows/task_runner_e2e.yml index 40d5d9bcc5c..b6c17c0bcda 100644 --- a/.github/workflows/task_runner_e2e.yml +++ b/.github/workflows/task_runner_e2e.yml @@ -38,7 +38,11 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: - model_name: [ "torch_cnn_mnist", "keras_cnn_mnist", "torch_cnn_histology", "tf_2dunet", "tf_cnn_histology" ] + # There are open issues for some of the models, so excluding them for now: + # 1. https://github.com/securefederatedai/openfl/issues/1126 + # 2. https://github.com/securefederatedai/openfl/issues/1127 + # model_name: [ "torch_cnn_mnist", "keras_cnn_mnist", "torch_cnn_histology", "tf_2dunet", "tf_cnn_histology" ] + model_name: [ "torch_cnn_mnist", "keras_cnn_mnist" ] fail-fast: false # do not immediately fail if one of the combinations fail env: MODEL_NAME: ${{ inputs.model_name == 'all' && matrix.model_name || inputs.model_name }} # run all models if model_name is not provided else run the provided model diff --git a/tests/openfl_e2e/test_suites/task_runner_tests.py b/tests/openfl_e2e/test_suites/task_runner_tests.py index 159ce5e52ed..2c7aab66cf2 100644 --- a/tests/openfl_e2e/test_suites/task_runner_tests.py +++ b/tests/openfl_e2e/test_suites/task_runner_tests.py @@ -38,7 +38,6 @@ def test_keras_cnn_mnist(fx_federation): assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed" -@pytest.mark.skip(reason="Test is under development") @pytest.mark.torch_cnn_histology def test_torch_cnn_histology(fx_federation): """ @@ -56,7 +55,6 @@ def test_torch_cnn_histology(fx_federation): assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed" -@pytest.mark.skip(reason="Test is under development") @pytest.mark.tf_2dunet def test_tf_2dunet(fx_federation): log.info(f"Test for tf_2dunet with fx_federation: {fx_federation}") @@ -71,7 +69,6 @@ def test_tf_2dunet(fx_federation): assert fed_helper.verify_federation_run_completion(fx_federation, results), "Federation completion failed" -@pytest.mark.skip(reason="Test is under development") @pytest.mark.tf_cnn_histology def test_tf_cnn_histology(fx_federation): log.info(f"Test for tf_cnn_histology with fx_federation: {fx_federation}")