Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a deterministic algorithm for choosing a port for the aggregator server. #342

Open
igor-davidyuk opened this issue Feb 17, 2022 · 1 comment · May be fixed by #400
Open

Introduce a deterministic algorithm for choosing a port for the aggregator server. #342

igor-davidyuk opened this issue Feb 17, 2022 · 1 comment · May be fixed by #400
Assignees
@mansishr
Labels
enhancement New feature or request
Milestone
v1.6

Comments

@igor-davidyuk
Copy link
Contributor

The workflow will probably be as follows:
Director config will feature a new parameter open_ports listing one or more ports.
This list will be tracked by the Director-service, which will provide one of the ports to the Aggregator at the start time.
@alexey-gruzdev alexey-gruzdev added this to the v1.4 milestone Feb 17, 2022
@igor-davidyuk igor-davidyuk modified the milestone: v1.4 Feb 17, 2022
@ladi-pomsar
Copy link

Hi,

Thank you for doing this. Motivation behind this is that when one is working on secure system, it is important to open just as much ports as is needed, in a controlled fashion. With aggregator picking "random" port, it is rather problematic to achieve minimalisation of open ports.

@dmitryagapov dmitryagapov self-assigned this Feb 21, 2022
@dmitryagapov dmitryagapov linked a pull request Feb 21, 2022 that will close this issue
Run collaborator in docker #280
Closed
@alexey-gruzdev alexey-gruzdev added the enhancement New feature or request label Feb 22, 2022
@dmitryagapov dmitryagapov removed a link to a pull request Mar 18, 2022
Run collaborator in docker #280
Closed
@mansishr mansishr linked a pull request Mar 25, 2022 that will close this issue
Open
@Einse57 Einse57 modified the milestones: v1.3.1, v1.5 Aug 30, 2022
@psfoley psfoley modified the milestones: v1.5, v1.6 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansishr mansishr

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.6
Development

Successfully merging a pull request may close this issue.

Choose a port for aggregator server mansishr/openfl
7 participants
@psfoley @dmitryagapov @Einse57 @ladi-pomsar @igor-davidyuk @alexey-gruzdev @mansishr