Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for samples in assays further in assay stream when creating an in-between assay. #1920

Open
NielsGeudens opened this issue Jun 13, 2024 · 0 comments
Labels
datahub belgiumHub project enhancement
Milestone

Comments

@NielsGeudens
Copy link
Collaborator

It is now possible to add an assay between two existing assays, providing the next assay does not contain samples. When having samples in the next assay, it provides an error when trying to add an in-between assay, as it should. (coded in #1656

However, when deleting the samples in the next assay (n+1) (thereby breaking the link with the assay further down (n+2), it does allow to insert the assay at position n. The user might think this is an 'okay solution' by first deleting the samples at assay n+1, then making the additional assay (position n), and then making samples again in assay n+1. However, the id of the samples will of course be different, and no longer linked to assay n+2.

is it possible to check the presence of samples in the assays further downstream rather than only in the next assay, and forbidding the creating of an in-between assay if any of the following assays contain samples?

@NielsGeudens NielsGeudens added enhancement datahub belgiumHub project labels Jun 13, 2024
@NielsGeudens NielsGeudens added this to the 1.16.0 milestone Jun 13, 2024
@github-project-automation github-project-automation bot moved this to Requirements in DataHub Jun 13, 2024
@stuzart stuzart modified the milestones: 1.16.0, 1.16.1 Nov 20, 2024
@stuzart stuzart modified the milestones: 1.16.1, 1.16.2 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project enhancement
Projects
Status: Requirements
Development

No branches or pull requests

2 participants