From c40c068364963225362af2a68698028b3eebd683 Mon Sep 17 00:00:00 2001 From: Alan Charles Date: Wed, 14 Feb 2024 10:00:34 -0700 Subject: [PATCH 1/2] change firebase plugin from public to open --- Sources/SegmentFirebase/FirebaseDestination.swift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Sources/SegmentFirebase/FirebaseDestination.swift b/Sources/SegmentFirebase/FirebaseDestination.swift index 2740d1b..71d35d1 100644 --- a/Sources/SegmentFirebase/FirebaseDestination.swift +++ b/Sources/SegmentFirebase/FirebaseDestination.swift @@ -37,11 +37,11 @@ import FirebaseAnalytics */ @objc(SEGFirebaseDestination) - public class ObjCFirebaseDestination: NSObject, ObjCPlugin, ObjCPluginShim { - public func instance() -> EventPlugin { return FirebaseDestination() } - } +open class ObjCFirebaseDestination: NSObject, ObjCPlugin, ObjCPluginShim { + public func instance() -> EventPlugin { return FirebaseDestination() } +} -public class FirebaseDestination: DestinationPlugin { +open class FirebaseDestination: DestinationPlugin { public let timeline = Timeline() public let type = PluginType.destination public let key = "Firebase" From 14833a61af2715fc6aedf95b1f2793f7ab29216e Mon Sep 17 00:00:00 2001 From: Alan Charles Date: Wed, 14 Feb 2024 10:48:30 -0700 Subject: [PATCH 2/2] change update from public to open --- Sources/SegmentFirebase/FirebaseDestination.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/SegmentFirebase/FirebaseDestination.swift b/Sources/SegmentFirebase/FirebaseDestination.swift index 71d35d1..7804962 100644 --- a/Sources/SegmentFirebase/FirebaseDestination.swift +++ b/Sources/SegmentFirebase/FirebaseDestination.swift @@ -52,8 +52,8 @@ open class FirebaseDestination: DestinationPlugin { public init(firebaseOptions: FirebaseOptions? = nil) { self.firebaseOptions = firebaseOptions } - - public func update(settings: Settings, type: UpdateType) { + + open func update(settings: Settings, type: UpdateType) { // we've already set up this singleton SDK, can't do it again, so skip. guard type == .initial else { return }