From bfb0e6f72885704cee6b95a485a3e816e90fe58e Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 14:11:37 -0500 Subject: [PATCH 01/11] add additional jest stuff --- .vscode/launch.json | 60 ++++++++++++--------------------------------- 1 file changed, 16 insertions(+), 44 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index c046791af..6c80a3c07 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -4,76 +4,48 @@ { "type": "node", "request": "launch", - "name": "Jest Current File", - "program": "${workspaceFolder}/node_modules/.bin/jest", - "args": ["--testTimeout=100000", "--findRelatedTests", "${relativeFile}"], - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen", - "skipFiles": ["/**"] - }, - { - "type": "node", - "request": "launch", - "name": "Jest Watch Current File", + "name": "Jest: current file", "program": "${workspaceFolder}/node_modules/.bin/jest", "args": [ "--testTimeout=100000", - "--watch", "--findRelatedTests", - "${relativeFile}" + "${relativeFile}", + "${input:additionalJestArgs}" ], "console": "integratedTerminal", "internalConsoleOptions": "neverOpen", "skipFiles": ["/**"] }, + { - "name": "Run Jest Tests for Current Package", + "name": "Jest: run for current package", "type": "node", "request": "launch", "program": "${workspaceFolder}/node_modules/.bin/jest", - "args": ["--testTimeout=100000"], - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen", - "cwd": "${fileDirname}" - }, - { - "type": "node", - "name": "Jest All", - "request": "launch", "args": [ "--testTimeout=100000", - "-c", - "${workspaceFolder}/jest.config.js" + "${input:additionalJestArgs}" ], - "cwd": "${workspaceFolder}", "console": "integratedTerminal", "internalConsoleOptions": "neverOpen", - "program": "${workspaceFolder}/node_modules/jest/bin/jest", - "skipFiles": ["/**"] - }, - { - "type": "node", - "name": "Jest All: Browser", - "request": "launch", - "args": [ - "--testTimeout=100000", - "-c", - "${workspaceFolder}/packages/browser/jest.config.js" - ], - "cwd": "${workspaceFolder}", - "console": "integratedTerminal", - "internalConsoleOptions": "neverOpen", - "program": "${workspaceFolder}/node_modules/jest/bin/jest", - "skipFiles": ["/**"] + "cwd": "${fileDirname}" }, { - "name": "ts-node Current File", + "name": "Run .ts script with ts-node: Current File", "type": "node", "request": "launch", "args": ["${relativeFile}"], "runtimeArgs": ["-r", "ts-node/register"], "cwd": "${workspaceRoot}", "internalConsoleOptions": "openOnSessionStart" + }, + ], + "inputs": [ + { + "id": "additionalJestArgs", + "type": "promptString", + "description": "Add additional Jest arguments (e.g., --watch, --runInBand, --coverage, --updateSnapshot)", + "default": "" } ] } From a8204e1de58785ba98d22b16eca9f1bc65620e1a Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 14:12:41 -0500 Subject: [PATCH 02/11] wip --- .vscode/launch.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 6c80a3c07..1e16e7ca1 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -31,7 +31,7 @@ "cwd": "${fileDirname}" }, { - "name": "Run .ts script with ts-node: Current File", + "name": "ts-node: execute current .ts file", "type": "node", "request": "launch", "args": ["${relativeFile}"], From 8d0f032e2d7b210474f7b72f5a3ea80fe906deeb Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 14:16:55 -0500 Subject: [PATCH 03/11] wip --- .vscode/launch.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 1e16e7ca1..b394250fe 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -4,7 +4,7 @@ { "type": "node", "request": "launch", - "name": "Jest: current file", + "name": "Jest - run related tests for current file", "program": "${workspaceFolder}/node_modules/.bin/jest", "args": [ "--testTimeout=100000", @@ -18,7 +18,7 @@ }, { - "name": "Jest: run for current package", + "name": "Jest - run _all_ tests for package of the current file", "type": "node", "request": "launch", "program": "${workspaceFolder}/node_modules/.bin/jest", @@ -31,7 +31,7 @@ "cwd": "${fileDirname}" }, { - "name": "ts-node: execute current .ts file", + "name": "ts-node - execute current .ts file/script", "type": "node", "request": "launch", "args": ["${relativeFile}"], From 500c0598c8f6ddb25021b9ca09a09612ff2fc1ed Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 14:40:45 -0500 Subject: [PATCH 04/11] wip --- .vscode/launch.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index b394250fe..de5188773 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -4,7 +4,7 @@ { "type": "node", "request": "launch", - "name": "Jest - run related tests for current file", + "name": "Jest - run only related tests for current file", "program": "${workspaceFolder}/node_modules/.bin/jest", "args": [ "--testTimeout=100000", @@ -43,8 +43,14 @@ "inputs": [ { "id": "additionalJestArgs", - "type": "promptString", - "description": "Add additional Jest arguments (e.g., --watch, --runInBand, --coverage, --updateSnapshot)", + "type": "pickString", + "description": "Select additional Jest arguments (optional)", + "options": [ + "--runInBand", + "--watch", + "--coverage", + "--updateSnapshot", + ], "default": "" } ] From 1bf18d4fa2de2476b6d8bb34643eb964aebf56ad Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 15:24:10 -0500 Subject: [PATCH 05/11] wip --- .vscode/launch.json | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index de5188773..dba0be7a1 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -9,6 +9,8 @@ "args": [ "--testTimeout=100000", "--findRelatedTests", + "--runInBand", + "--verbose", "${relativeFile}", "${input:additionalJestArgs}" ], @@ -16,18 +18,19 @@ "internalConsoleOptions": "neverOpen", "skipFiles": ["/**"] }, - { - "name": "Jest - run _all_ tests for package of the current file", + "name": "Jest - run _all_ tests for current file's package", "type": "node", "request": "launch", "program": "${workspaceFolder}/node_modules/.bin/jest", "args": [ "--testTimeout=100000", + "--runInBand", "${input:additionalJestArgs}" ], "console": "integratedTerminal", "internalConsoleOptions": "neverOpen", + "skipFiles": ["/**"], "cwd": "${fileDirname}" }, { @@ -38,20 +41,27 @@ "runtimeArgs": ["-r", "ts-node/register"], "cwd": "${workspaceRoot}", "internalConsoleOptions": "openOnSessionStart" - }, + } ], "inputs": [ { "id": "additionalJestArgs", "type": "pickString", - "description": "Select additional Jest arguments (optional)", + "description": "(Optional) Select additional Jest arguments", "options": [ - "--runInBand", - "--watch", - "--coverage", - "--updateSnapshot", + { "label": "none", "value": "" }, + { "label": "", "value": "--watch" }, + { "label": "", "value": "--updateSnapshot" }, + { "label": "", "value": "--coverage" }, + { "label": "", "value": "--runInBand" } ], "default": "" + }, + { + "id": "packageName", + "type": "pickString", + "description": "Select a package to debug", + "options": ["@segment/analytics-", "package-b", "package-c"] } ] } From 1922a0b6614387d4f9d3bf8b2427ea17092bcc7d Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 15:37:11 -0500 Subject: [PATCH 06/11] add noEmit false to build, noEmit true to root --- packages/browser/tsconfig.build.json | 1 + packages/consent/consent-tools/tsconfig.build.json | 1 + packages/consent/consent-wrapper-onetrust/tsconfig.build.json | 1 + packages/core/tsconfig.build.json | 1 + packages/generic-utils/tsconfig.build.json | 1 + packages/node/tsconfig.build.json | 1 + packages/page-tools/tsconfig.build.json | 1 + packages/signals/signals-runtime/tsconfig.build.json | 1 + packages/signals/signals/tsconfig.build.json | 1 + packages/test-helpers/tsconfig.build.json | 1 + tsconfig.json | 3 ++- 11 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/browser/tsconfig.build.json b/packages/browser/tsconfig.build.json index ae2c8deae..2ce0b6877 100644 --- a/packages/browser/tsconfig.build.json +++ b/packages/browser/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/test-helpers/**", "**/tester/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/pkg", "declarationDir": "./dist/types" } diff --git a/packages/consent/consent-tools/tsconfig.build.json b/packages/consent/consent-tools/tsconfig.build.json index b74e28ced..9dd151989 100644 --- a/packages/consent/consent-tools/tsconfig.build.json +++ b/packages/consent/consent-tools/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/consent/consent-wrapper-onetrust/tsconfig.build.json b/packages/consent/consent-wrapper-onetrust/tsconfig.build.json index c11c2b9dd..6b091bfd8 100644 --- a/packages/consent/consent-wrapper-onetrust/tsconfig.build.json +++ b/packages/consent/consent-wrapper-onetrust/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/test-helpers/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/core/tsconfig.build.json b/packages/core/tsconfig.build.json index 830170446..59298244b 100644 --- a/packages/core/tsconfig.build.json +++ b/packages/core/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/*.test.*"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/generic-utils/tsconfig.build.json b/packages/generic-utils/tsconfig.build.json index 830170446..59298244b 100644 --- a/packages/generic-utils/tsconfig.build.json +++ b/packages/generic-utils/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/*.test.*"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/node/tsconfig.build.json b/packages/node/tsconfig.build.json index b74e28ced..9dd151989 100644 --- a/packages/node/tsconfig.build.json +++ b/packages/node/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/page-tools/tsconfig.build.json b/packages/page-tools/tsconfig.build.json index 55432f7ad..8b6e17dc1 100644 --- a/packages/page-tools/tsconfig.build.json +++ b/packages/page-tools/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**"], "compilerOptions": { + "noEmit": false // Options tsup Ignores: // module: tsup always outputs ESM or CommonJS based on its --format option. // outDir: tsup uses its own --out-dir option to control output. diff --git a/packages/signals/signals-runtime/tsconfig.build.json b/packages/signals/signals-runtime/tsconfig.build.json index c11c2b9dd..6b091bfd8 100644 --- a/packages/signals/signals-runtime/tsconfig.build.json +++ b/packages/signals/signals-runtime/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/test-helpers/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/signals/signals/tsconfig.build.json b/packages/signals/signals/tsconfig.build.json index c11c2b9dd..6b091bfd8 100644 --- a/packages/signals/signals/tsconfig.build.json +++ b/packages/signals/signals/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/test-helpers/**"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/packages/test-helpers/tsconfig.build.json b/packages/test-helpers/tsconfig.build.json index 830170446..59298244b 100644 --- a/packages/test-helpers/tsconfig.build.json +++ b/packages/test-helpers/tsconfig.build.json @@ -3,6 +3,7 @@ "include": ["src"], "exclude": ["**/__tests__/**", "**/*.test.*"], "compilerOptions": { + "noEmit": false, "outDir": "./dist/esm", "declarationDir": "./dist/types" } diff --git a/tsconfig.json b/tsconfig.json index 249c71204..4150021c2 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -9,7 +9,8 @@ "sourceMap": true, "declaration": true, "declarationMap": true, - "importHelpers": true + "importHelpers": true, + "noEmit": true }, "ts-node": { "transpileOnly": true, From b9e0126b48275563ba6ffaf7228cdc2a0b13a553 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 16:02:52 -0500 Subject: [PATCH 07/11] update --- package.json | 1 + turbo.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 55e7f3f10..2e6adff71 100644 --- a/package.json +++ b/package.json @@ -17,6 +17,7 @@ "test:check-dts": "yarn build && yarn ts-node meta-tests/check-dts.ts", "test:node-int": "turbo run --filter=node-integration-tests test", "lint": "yarn constraints && turbo run lint --continue", + "typecheck": "turbo run tsc --filter='./packages/**'", "build": "turbo run build --filter='./packages/**'", "watch": "turbo run watch --filter='./packages/**'", "dev": "yarn workspace @playground/next-playground run dev", diff --git a/turbo.json b/turbo.json index 095bceb5b..959f99e86 100644 --- a/turbo.json +++ b/turbo.json @@ -47,7 +47,7 @@ ] }, "tsc": { - "cache": false + "dependsOn": ["^build:esm"] }, "assert-generated": { "cache": false From 90931af75f703559db9224983bc2f3a681a12ca8 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 16:06:49 -0500 Subject: [PATCH 08/11] update prepush --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2e6adff71..d2bef7acb 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "turbo run build --filter='./packages/**'", "watch": "turbo run watch --filter='./packages/**'", "dev": "yarn workspace @playground/next-playground run dev", - "prepush": "turbo run lint --filter='...[master...HEAD]'", + "prepush": "turbo run typecheck --affected", "postinstall": "husky install", "changeset": "changeset", "update-versions-and-changelogs": "changeset version && yarn version-run-all && bash scripts/update-lockfile.sh", From 498ab3ab5f8bdb9f6fbb8c9706e1e3ddb411b6ea Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 16:07:03 -0500 Subject: [PATCH 09/11] wip --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d2bef7acb..207a3b184 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "turbo run build --filter='./packages/**'", "watch": "turbo run watch --filter='./packages/**'", "dev": "yarn workspace @playground/next-playground run dev", - "prepush": "turbo run typecheck --affected", + "prepush": "yarn run typecheck --affected", "postinstall": "husky install", "changeset": "changeset", "update-versions-and-changelogs": "changeset version && yarn version-run-all && bash scripts/update-lockfile.sh", From 0b148c7e82abcdf5e87675cf725d66c2d5449391 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 16:07:33 -0500 Subject: [PATCH 10/11] add prepush --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 207a3b184..ef6b08a9c 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "turbo run build --filter='./packages/**'", "watch": "turbo run watch --filter='./packages/**'", "dev": "yarn workspace @playground/next-playground run dev", - "prepush": "yarn run typecheck --affected", + "prepush": "yarn run tsc --affected", "postinstall": "husky install", "changeset": "changeset", "update-versions-and-changelogs": "changeset version && yarn version-run-all && bash scripts/update-lockfile.sh", From 23dba42829ca55c1af06f1f7723a586dc02f225b Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Fri, 2 May 2025 16:07:53 -0500 Subject: [PATCH 11/11] wip --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ef6b08a9c..7f0cc1163 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build": "turbo run build --filter='./packages/**'", "watch": "turbo run watch --filter='./packages/**'", "dev": "yarn workspace @playground/next-playground run dev", - "prepush": "yarn run tsc --affected", + "prepush": "turbo run tsc --affected", "postinstall": "husky install", "changeset": "changeset", "update-versions-and-changelogs": "changeset version && yarn version-run-all && bash scripts/update-lockfile.sh",