forked from LoveDaisy/tetris_game
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitAuto: 対戦環境を構築する #22
Open
gitauto-ai
wants to merge
22
commits into
master
Choose a base branch
from
gitauto/issue-#19-74740e0d-e181-42c3-b67a-e057e17e5c60
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GitAuto: 対戦環境を構築する #22
gitauto-ai
wants to merge
22
commits into
master
from
gitauto/issue-#19-74740e0d-e181-42c3-b67a-e057e17e5c60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19
What is the feature
Implement a battle environment that enables players to compete against each other in real-time, expanding the current functionality beyond the single-player score attack mode.
Why we need the feature
Introducing a battle environment will enhance user engagement by providing a competitive multiplayer experience. This feature will attract a broader user base, encourage community interaction, and add depth to the gameplay, making the application more appealing and enjoyable.
How to implement and why
To implement the battle environment, the following steps are proposed:
Modify
game_manager
Module:game_manager
to handle multiple players simultaneously.Update
block_controller.py
:Enhance Networking Capabilities:
Revise
start.sh
Script:Update Documentation in
doc
Directory:Adjust Docker Configuration:
Implement Lobby and Match Management:
Conduct Thorough Testing:
By following these steps, we can systematically build a robust battle environment. Each step ensures that the new feature integrates smoothly with the existing codebase while maintaining performance and code quality.
About backward compatibility
By keeping the new feature optional and ensuring it does not disrupt existing functionality, we maintain backward compatibility and respect the preferences of current users.
Test these changes locally