Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Missing typescript definitions #1

Open
rombrom opened this issue May 18, 2016 · 6 comments
Open

Missing typescript definitions #1

rombrom opened this issue May 18, 2016 · 6 comments

Comments

@rombrom
Copy link

rombrom commented May 18, 2016

Hi! Could there be a possibility of adding typescript definitions so the ng2-ace module plays nicely with Angular2/Typescript? Thanks!

@seiyria
Copy link
Owner

seiyria commented May 18, 2016

If you PR them, I'll take it. I don't use typescript and have no interest in it at this point in time.

@cyberbeast
Copy link

Would really appreciate the addition of the typescript definitions. :)

@seiyria
Copy link
Owner

seiyria commented Jul 24, 2016

+1s are just noise. As I said I have no interest in it, so if you want it you will need to pr it to me.

@jLouzado
Copy link

jLouzado commented Aug 1, 2016

I'd like to work on this; quite need this plugin for a project I'm working on. Does that mean that I'd have to port the entire project over to Typescript to then write the typings? Any nudge in the right direction would be greatly appreciated...

@seiyria
Copy link
Owner

seiyria commented Aug 1, 2016

I'm pretty sure you just need to make a .ts.d file that matches the projects API. I'm not sure what you need to do past that, though.

@sinedied
Copy link

In the meantime, any idea how to make this work with an angular2/typescript project generated by angular-cli?

When writing this import { AceEditorDirective } from 'ng2-ace'; I have an error:

Cannot find module 'ng2-ace'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants