Skip to content
This repository was archived by the owner on May 19, 2022. It is now read-only.

"Autoplay speed" setting doesn't save #22

Open
PieFormation opened this issue Mar 15, 2014 · 6 comments
Open

"Autoplay speed" setting doesn't save #22

PieFormation opened this issue Mar 15, 2014 · 6 comments

Comments

@PieFormation
Copy link

The "Autoplay speed" setting in the Configuration menu does not save properly.

To reproduce:

  1. Open the configuration menu
  2. Change Autoplay speed
  3. Save the game (or don't, you get the same behavior, but the point being it does this even if the game is saved immediately after changing it)
  4. Load any save file or return to title
  5. Check configuration menu again, Autoplay speed will have returned to default.

Win7 64-bit.

@Jadomonkey
Copy link

I'm experiencing that too, but the save game seems to preserve the setting for that play, it just doesn't seem to preserve the setting otherwise.

@euank
Copy link
Contributor

euank commented Mar 27, 2014

I'm pretty sure this is purely a script issue.

This bit is for anyone who feels like digging into it further; in the compiled script file I found the following bits of interest: %sys_auto_time is init at *title (line 249) regardless of previous value. Other, properly saved variables, are init in *first_init (1281).

I don't know enough about the script to be sure if there's a deeper reason for this and it would be nice if someone who knew more could comment.

All the same, thanks for the report. Sorry I've let it sit for so long, I suspected it was script-related rather than engine related from the beginning and was hoping to get confirmation.

@Yirba
Copy link

Yirba commented Mar 27, 2014

It definitely sounds like a script issue. It should be fine with some slight adjustment to the script.

@Jadomonkey
Copy link

Is it possible that was intentional or tied to autoplay by default?

@Yirba
Copy link

Yirba commented Mar 27, 2014

I can't see it being intentional. NScripter is a little odd regarding which variables get saved and which don't, so it's an easy error to occur. We'll definitely take a look at it to make sure it doesn't occur in the final release.
I'm not sure if PONScripter supports negative automode_time values, which might be something interesting to look into.

@Jadomonkey
Copy link

Actually, after playing with it some more, if you finish a chapter and select a new one in either side 1 or 2, it preserves the setting. The only time I see it reset on its own is when going to the main title screen or loading a save which preserves the setting set for that playthrough.

@euank euank added bug and removed duplicate labels Apr 20, 2014
@euank euank added narcissu and removed osx only labels Apr 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants