Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MKS-4439]Add checking local_volume with volume_type #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MKS-4439]Add checking local_volume with volume_type #303

wants to merge 2 commits into from

Conversation

Artem23-coder
Copy link

@Artem23-coder Artem23-coder commented Oct 10, 2024 •
edited
Loading

This PR will resolve #300

Changes:

  1. Add checking that, we can't use local_volume = false with not empty value for volume_type

@Artem23-coder Artem23-coder force-pushed the fix-volume-type-with-local-volume branch from 922e1bc to 620ac14 Compare October 11, 2024 11:08
@TawR1024 TawR1024 added the bug label Oct 29, 2024
TawR1024
TawR1024 previously approved these changes Nov 26, 2024
View reviewed changes
@Artem23-coder Artem23-coder force-pushed the fix-volume-type-with-local-volume branch from d967bd2 to 431a65d Compare November 27, 2024 14:03
@Artem23-coder Artem23-coder force-pushed the fix-volume-type-with-local-volume branch from 9ce510b to 21852f4 Compare November 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bablzz Bablzz Bablzz left review comments

@pavelpereyma pavelpereyma pavelpereyma approved these changes

@TawR1024 TawR1024 TawR1024 left review comments

@kolsean kolsean Awaiting requested review from kolsean

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volume_type conflicts with "local_type = false" in mks nodegroup
4 participants
@Artem23-coder @Bablzz @pavelpereyma @TawR1024