Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejeto HFS 3 Pull Request #531

Closed
wants to merge 29 commits into from
Closed

Conversation

bmartino1
Copy link

I'm attempting to follow another users comment to initiate a pull request:

Per following a issue to make a xml Template for a New CA App.
#530

templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
@nwithan8 nwithan8 requested a review from Roxedus October 31, 2024 05:49
bmartino1 and others added 9 commits October 31, 2024 00:57
mac address was optional. Dependent on network end user chooses.

Co-authored-by: Nate Harris <[email protected]>
@bmartino1
Copy link
Author

All edits looked fine to bring to a nicer default template install.
I have reviewed the updated xml after all the commits and verified that they work for a default install.

Thank You nwithan8 for your assistance on this.

Needs to be .key
HFS as that coded to read a .key file won't accept .pem
Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line-ending characters.
Remove pre-set values.

templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
templates/rejettohfs3.xml Outdated Show resolved Hide resolved
bmartino1 and others added 11 commits October 31, 2024 14:32
using hfs template variable for ports...

Co-authored-by: Roxedus <[email protected]>
the default port is actual 80 for web ui use they moved to 8080... moving ot 8080 for a bridge network would be best. when macvlan / ipvlan and set to its own IP aditioanl ports in extra are ignored as all ports are forwarded...

Co-authored-by: Roxedus <[email protected]>
fixed webui pull call
Added ports back. Required for Ports to work in Bridge mode...
Added ReadMe First...
updated HFS VFS https ports to 60443 as bridge will overwrite unraids 443...
readded HFS VFS http ports to default 8080
Fixed Web UI open link to admin page
added Docker needed bridge port forwards as variables instead of extra options...
@bmartino1
Copy link
Author

Like other unraid CA templates, simlar to Pihole this realy should be a IPVLan / MacVLan Custom network.

added data to use on HFS default bridge mode.

Copy link
Author

@bmartino1 bmartino1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Fixed template to empty but default working form...
netwrok Bridge Does not work!

tried to add readme first file:
https://raw.githubusercontent.com/bmartino1/hfs-docker/refs/heads/main/Unraid_ReadMeFirst.txt
@bmartino1
Copy link
Author

tried to add the readme first
https://raw.githubusercontent.com/bmartino1/hfs-docker/refs/heads/main/Unraid_ReadMeFirst.txt

Had to revert the authoring template back to a custom network and docker bridge network would not funtion or work...

Removed empty old data content per nwithan8 pull commits
Default end user pathing:

/mnt/user/appdata/rejettohfs3/
add warning about static ip to Overview
@bmartino1
Copy link
Author

Screenshot 2024-10-31 162743

Similar to this docker with a warning

This template will need a custom static IP.

@bmartino1
Copy link
Author

Thank you Both/ALL for your assistance and work on this. I have been in contact with Squid and have made a separate repository:
https://github.com/bmartino1/unraid-docker-templates

@bmartino1 bmartino1 closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants