Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same type for the group id in the @semaphore-protocol/group and @semaphore-protocol/data packages. #323

Open
vplasencia opened this issue May 15, 2023 · 1 comment
Open

Use the same type for the group id in the @semaphore-protocol/group and @semaphore-protocol/data packages. #323

vplasencia opened this issue May 15, 2023 · 1 comment
Labels
good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest. refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@vplasencia
Copy link
Member

Right now, to create a group, the id could be a BigNumberish but to use the group id in any of the functions in the SemaphoreSubgraph or SemaphoreEthers classes in the @semaphore-protocol/data package, the id should be a string.
@vplasencia vplasencia added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label May 15, 2023
@cedoor cedoor moved this to ♻️ Grooming in Semaphore Board May 15, 2023
@cedoor cedoor added good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest. labels Oct 3, 2024
@hannahredler
Copy link

hannahredler commented Nov 2, 2024 •
edited
Loading

Hey! I'm a former student of the PSE Core Program. If this is available I'd happily take a look at it :) @vplasencia @cedoor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest. refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Semaphore Board
Status: ♻️ Grooming
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cedoor @vplasencia @hannahredler