Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semaphore event listeners #326

Open
aguzmant103 opened this issue May 16, 2023 · 2 comments
Open

Add Semaphore event listeners #326

aguzmant103 opened this issue May 16, 2023 · 2 comments
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest.

Comments

@aguzmant103
Copy link
Contributor

aguzmant103 commented May 16, 2023

Description

The @semaphore-protocol/data library currently provides functions to download data from deployed contracts using mainly events with Ethers or TheGraph subgraphs.

However, there are no listeners, which can be useful for keeping the list of local groups, members, or proofs up-to-date.

Resources

@aguzmant103 aguzmant103 converted this from a draft issue May 16, 2023
@vplasencia vplasencia added the feature 🚀 This is enhancing something existing or creating something new label Sep 1, 2023
@cedoor cedoor added good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest. labels Oct 3, 2024
@0xshikhar
Copy link
Contributor

Hey @cedoor, would love to work on this ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@cedoor
Copy link
Member

cedoor commented Oct 15, 2024

Hi @0xshikhar, ofc! The following listeners need to be added to the SemaphoreEthers class:

  • onGroup (GroupCreated event): should return the group id of the newly created group.
  • onMember (MemberRemoved, MemberUpdated, MemberAdded events): should return the identity commitment of members who are added/updated/removed. In case of updates or removals, the old id commitment should also be returned.
  • onValidatedProof (ProofValidated event): should return the parameters of a validated proof.
  • onGroupAdmin (GroupAdminUpdated event): should return the address of the old admin and the new one.

Ethers doc: https://docs.ethers.org/v6/api/utils/events/

@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in Semaphore Board Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers hacktoberfest Encourages contributions to open source during Hacktoberfest.
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

4 participants