Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The subgraph getGroups function returns wrong members #858

Open
vplasencia opened this issue Sep 30, 2024 · 4 comments
Open

The subgraph getGroups function returns wrong members #858

vplasencia opened this issue Sep 30, 2024 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working good first issue Good for newcomers

Comments

@vplasencia
Copy link
Member

Description

If there are two members in an on-chain Semaphore group and one of the members is removed, the getGroup function from the SemaphoreSubgraph class returns the old value of the member instead of the new value that should be 0.

It looks like the function does not take into account when a member is removed (probably also when the member is updated).

@AjayAdsule
Copy link

AjayAdsule commented Nov 2, 2024

@vplasencia should i work on it, if yes please assign to me

@vplasencia
Copy link
Member Author

Hey @AjayAdsule! Feel free to start working on it.

@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Nov 20, 2024
@cedoor cedoor added the good first issue Good for newcomers label Nov 20, 2024
@vplasencia
Copy link
Member Author

Hey @AjayAdsule! This is a priority task now and should be solved asap before ETHIndia. Then I will assign this task to someone who will start to work on it now. Sorry about it but please, feel free to pick any other issues you like.

@waddaboo
Copy link
Contributor

@vplasencia Hey! I can work on it, can you assign it to me? Thanks in advance!

@vplasencia vplasencia assigned waddaboo and vplasencia and unassigned AjayAdsule and waddaboo Nov 27, 2024
@vplasencia vplasencia moved this from 🏗 In Progress to 🗒 Tasks in Semaphore Board Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good for newcomers
Projects
Status: 🗒 Tasks
Development

No branches or pull requests

4 participants