Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of typed metavariable patterns for C# #513

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parsing of typed metavariable patterns for C# #513

wants to merge 2 commits into from

Conversation

mjambon
Copy link
Member

@mjambon mjambon commented Sep 28, 2024 •
edited
Loading

I updated our syntax extension for typed_metavariable to match what's now done for cast_expression in tree-sitter-c-sharp.

The PR that uses this code is https://github.com/semgrep/semgrep-proprietary/pull/2340

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

@mjambon mjambon requested a review from a team as a code owner September 28, 2024 02:17
@aryx aryx requested a review from ihji October 9, 2024 08:33
@aryx
Copy link
Collaborator

aryx commented Oct 9, 2024

@ihji is our metavariable-type expert so he may have a comment but otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryx aryx aryx approved these changes

@brandonspark brandonspark Awaiting requested review from brandonspark

@ihji ihji Awaiting requested review from ihji

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjambon @aryx