Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release packages ship with outdated version 2.3.2 of libsemigroups #968

Closed
rawrunprotected opened this issue Jan 3, 2024 · 3 comments
Closed

Comments

@rawrunprotected
Copy link

Noticed this while investigating possible performance issues working with a rather large semigroup.

The external version for libsemigroups in https://github.com/semigroups/Semigroups/blob/main/.LIBSEMIGROUPS_VERSION is currently set to 2.3.2. This release of libsemigroups is lacking some at least one fix critical for performance that is ironically enough fixed for the version directly included in Semigroups: libsemigroups/libsemigroups#418 only made it into https://github.com/libsemigroups/libsemigroups/tree/v2.4.1. As a result, current releases of the Semigroups package, and by transitivity current releases of gap, will likely leave quite a bit of performance on the table.

I would have liked to open a PR myself to bump the version, but I wasn't able to successfully build Semigroups locally for testing yet.

@james-d-mitchell
Copy link
Collaborator

Good point, this should be simple to resolve. I'll try to bump the version and make a new release tomorrow. If you're having any issues with building Semigroups feel free to post another issue or add something here

@james-d-mitchell
Copy link
Collaborator

Resolved by #969, I'll start the release process now too.

@james-d-mitchell
Copy link
Collaborator

Hopefully resolved in v5.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants