Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create firehose-protos-examples to fix circular dependency issue #34

Merged

Conversation

suchapalaver
Copy link
Contributor

No description provided.

@suchapalaver suchapalaver self-assigned this Oct 29, 2024
Copy link

linear bot commented Oct 29, 2024

@suchapalaver suchapalaver force-pushed the joseph/back-119-fix-cyclical-dependency-in-veemon branch 2 times, most recently from 561b6fb to ae57f87 Compare October 29, 2024 21:21
@suchapalaver suchapalaver marked this pull request as ready for review October 29, 2024 21:23
@suchapalaver suchapalaver force-pushed the joseph/back-119-fix-cyclical-dependency-in-veemon branch from ae57f87 to 2dae343 Compare October 29, 2024 21:28
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be refactor? You're moving code between crates.

@suchapalaver suchapalaver force-pushed the joseph/back-119-fix-cyclical-dependency-in-veemon branch from 2dae343 to a53feb3 Compare October 29, 2024 23:03
@suchapalaver suchapalaver requested a review from anirudh2 October 29, 2024 23:03
@suchapalaver suchapalaver changed the title fix: create firehose-protos-examples to fix circular dependency issue refactor: create firehose-protos-examples to fix circular dependency issue Oct 29, 2024
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!

@suchapalaver suchapalaver merged commit f11bf61 into main Oct 29, 2024
8 checks passed
@suchapalaver suchapalaver deleted the joseph/back-119-fix-cyclical-dependency-in-veemon branch October 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants