Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sendgrid dependency to 2.0 #25

Open
mozeryansky opened this issue May 29, 2016 · 2 comments
Open

Update sendgrid dependency to 2.0 #25

mozeryansky opened this issue May 29, 2016 · 2 comments

Comments

@mozeryansky
Copy link

According to package.json this transport uses sendgrid ^1.8.0, but you have recently released 2.0.0
@faridnsh
Copy link

faridnsh commented May 3, 2017

Now it is 5.0.1

@mozeryansky
Copy link
Author

The README of this repo now reads: "As of June 1, 2016, SendGrid will no longer support this library.".

Sendgrid actually updated the readme to say that the day after I submitted this issue. So that seemed to be their response, which is ok, it's a very large API change.

@Berkmann18 Berkmann18 mentioned this issue Jan 5, 2018
Closed
Berkmann18 added a commit to Berkmann18/nodemailer-sendgrid-transport that referenced this issue Jan 7, 2018
@Berkmann18
Updated dependency versions due to vulnerabilities found
9d03a23 
License date changed to an up-to-date one
This commit should resolve sendgrid#25 and sendgrid#63.
@Berkmann18 Berkmann18 mentioned this issue Jan 7, 2018
Closed
6 tasks
@Berkmann18 Berkmann18 mentioned this issue Jul 26, 2018
Closed
6 tasks
Berkmann18 added a commit to Berkmann18/sendgrid-nodejs that referenced this issue Jul 27, 2018
@Berkmann18
Integration of nodemailer-sendgrid-transport
223b00d 
I also refactored some of it such that it contains only the necessary
files, as well as follow the structure that the other sub-packages
follow.

This commit should help with the PRs:
- [NST#67](sendgrid/nodemailer-sendgrid-transport#67)
- [NST#64](sendgrid/nodemailer-sendgrid-transport#64)

And the following issues:
- [NST#65](sendgrid/nodemailer-sendgrid-transport#65)
- [NST#25](sendgrid/nodemailer-sendgrid-transport#25)

The problem I face despit this commit being here is that some
sub-packages require the old `sendgrid` package which works differently
then this one.
@Berkmann18 Berkmann18 mentioned this issue Jul 27, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated dependency versions due to vulnerabilities found Berkmann18/nodemailer-sendgrid-transport
4 participants
@thinkingserious @mbernier @faridnsh @mozeryansky