Refactor Attachment class create method for Mail class

packages/helpers/classes/attachment.d.ts

@@ -30,4 +30,6 @@ export default class Attachment implements AttachmentData {
   setDisposition(disposition: string): void;
   setContentId(contentId: string): void;
   toJSON(): AttachmentJSON;
+  static create(data: AttachmentData | Attachment): Attachment;
+  static create(data: AttachmentData[] | Attachment[]): Attachment[];
 }

packages/helpers/classes/attachment.js

@@ -181,6 +181,19 @@ class Attachment {
     //Return
     return toSnakeCase(json);
   }
+
+  static create(data) {
+    if(Array.isArray(data)) {
+      return data.filter(Boolean).map(item => this.create(item));
+    }
+    //Already instance of Attachment class?
+    if (data instanceof Attachment) {
+      return data;
+    }
+
+    //Create instance
+    return new Attachment(data);
+  }
 }
 
 //Export class

packages/helpers/classes/mail.js

@@ -5,6 +5,7 @@
  */
 const EmailAddress = require('./email-address');
 const Personalization = require('./personalization');
+const Attachment = require('./attachment');
 const toCamelCase = require('../helpers/to-camel-case');
 const toSnakeCase = require('../helpers/to-snake-case');
 const deepClone = require('../helpers/deep-clone');
@@ -388,7 +389,7 @@ class Mail {
       if (!attachments.every(attachment => !attachment.disposition || typeof attachment.disposition === 'string')) {
         throw new Error('Expected the attachment\'s `disposition` field to be a string');
       }
-      this.attachments = attachments;
+      this.attachments = Attachment.create(attachments);
     }
   }
 

packages/helpers/classes/mail.spec.js

@@ -185,6 +185,23 @@ describe('Mail', function() {
           }],
         })).to.throw('filename');
       });
+
+      it('properly handles attachment contentId', () => {
+        const contentId = 'test-content-id';
+        const mail = new Mail({
+          to: '[email protected]',
+          attachments: [{
+            disposition: 'inline',
+            content: 'test-content',
+            filename: 'name-that-file',
+            type: 'file-type',
+            contentId,
+          }],
+        });
+        const mainJSON = mail.toJSON();
+        const firstAttachment = mainJSON.attachments[0];
+        expect(firstAttachment.content_id).to.equal(contentId);
+      });
     });
   });