Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodemailer-sendgrid-transport to /packages #437

Closed
thinkingserious opened this issue Aug 31, 2017 · 15 comments
Closed

Add nodemailer-sendgrid-transport to /packages #437

thinkingserious opened this issue Aug 31, 2017 · 15 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

Please see issue sendgrid/nodemailer-sendgrid-transport#28

We want to upgrade that repo and bring it into this monorepo, then deprecate the old package.

@iifeoluwa
Copy link

iifeoluwa commented Oct 12, 2017

Hi @thinkingserious
Can you please shed a little more light on what you hope to achieve? My understanding of this is we need to move the sendgrid-transport module here (/packages). Is it just that?
Thanks!

@thinkingserious
Copy link
Contributor Author

Hi @iifeoluwa,

We need to do what you describe and update the dependency to match the current version of this SDK.

Thanks!

With Best Regards,

Elmer

@iifeoluwa
Copy link

Alright, great! @thinkingserious

One more thing though. I was thinking you'd want to merge this PR first before we move the package over.

Moving the package here and recreating the PR might be problematic. What do you think?

Regards.

@thinkingserious
Copy link
Contributor Author

Hi @iifeoluwa,

That is a great PR, but it's not using the latest version of this SDK.

@iifeoluwa
Copy link

Alright then, I'll get on with it.

Thanks @thinkingserious

@iifeoluwa
Copy link

Hello @thinkingserious,

I'm sorry, I won't be able to take this on at the moment. I might get back to it when I have enough time to go through how nodemailer's transport plugin and the mail package API works.

I don't know enough about it right now and wouldn't want to make a mess of things. I apologize for any inconvenience caused.

Regards.

@andris9
Copy link

andris9 commented Oct 23, 2017

Nodemailer author here. Just FYI I created SendGrid transport module for Nodemailer that is fully compatible (or as much compatible as possible) with Nodemailer API and uses the "@sendgrid/mail" module under the hood to do the actual delivery. You can find the module here: https://github.com/nodemailer/nodemailer-sendgrid

The main reason I created this module was to demonstrate how to use the internal normalize method available for transports. This method takes nodemailer message structure and converts it to a JSON compatible object that can be used by APIs like SendGrid (all attachments and such are normalized to base64 strings).

update I just realized that the repo was private, so if anyone clicked on the repo link, it probably was 404. Made the repo public.

@mbernier mbernier removed difficulty: easy fix is easy in difficulty difficulty: hard fix is hard in difficulty difficulty: very hard fix is very hard in difficulty difficulty: medium fix is medium in difficulty labels Oct 27, 2017
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty up-for-grabs labels Mar 5, 2018
@Berkmann18
Copy link
Contributor

Is there any update regarding the addition of nodemailer-sendgrid-transport?

@thinkingserious
Copy link
Contributor Author

Not yet @Berkmann18, this is still working its way up our backlog. Thanks for checking in!

@Berkmann18
Copy link
Contributor

Okay, thanks for letting me know.

@mauricetmeyer
Copy link

Is this issue still relevant? I would give it a go.

@Berkmann18
Copy link
Contributor

@mauricetmeyer Judging by the fact that #707 is still hanging and possibly other PRs then I would guess so.

@thinkingserious
Copy link
Contributor Author

My apologies for the confusion @mauricetmeyer, I had not updated the labels on this one. I do hope you will consider another issue, there's lots to do :)

Thanks for helping out @Berkmann18!

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed help wanted status: help wanted requesting help from the community labels Oct 9, 2018
@yilinglu
Copy link

What is the status of this issue? Anything more needed to be done?

@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

8 participants