-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodemailer-sendgrid-transport to /packages #437
Comments
Hi @thinkingserious |
Hi @iifeoluwa, We need to do what you describe and update the dependency to match the current version of this SDK. Thanks! With Best Regards, Elmer |
Alright, great! @thinkingserious One more thing though. I was thinking you'd want to merge this PR first before we move the package over. Moving the package here and recreating the PR might be problematic. What do you think? Regards. |
Hi @iifeoluwa, That is a great PR, but it's not using the latest version of this SDK. |
Alright then, I'll get on with it. Thanks @thinkingserious |
Hello @thinkingserious, I'm sorry, I won't be able to take this on at the moment. I might get back to it when I have enough time to go through how nodemailer's transport plugin and the mail package API works. I don't know enough about it right now and wouldn't want to make a mess of things. I apologize for any inconvenience caused. Regards. |
Nodemailer author here. Just FYI I created SendGrid transport module for Nodemailer that is fully compatible (or as much compatible as possible) with Nodemailer API and uses the "@sendgrid/mail" module under the hood to do the actual delivery. You can find the module here: https://github.com/nodemailer/nodemailer-sendgrid The main reason I created this module was to demonstrate how to use the internal update I just realized that the repo was private, so if anyone clicked on the repo link, it probably was 404. Made the repo public. |
Is there any update regarding the addition of nodemailer-sendgrid-transport? |
Not yet @Berkmann18, this is still working its way up our backlog. Thanks for checking in! |
Okay, thanks for letting me know. |
Is this issue still relevant? I would give it a go. |
@mauricetmeyer Judging by the fact that #707 is still hanging and possibly other PRs then I would guess so. |
My apologies for the confusion @mauricetmeyer, I had not updated the labels on this one. I do hope you will consider another issue, there's lots to do :) Thanks for helping out @Berkmann18! |
What is the status of this issue? Anything more needed to be done? |
Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you! |
Issue Summary
Please see issue sendgrid/nodemailer-sendgrid-transport#28
We want to upgrade that repo and bring it into this monorepo, then deprecate the old package.
The text was updated successfully, but these errors were encountered: