Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full provenance info to metadata.tsv files #251

Closed
maxsibilla opened this issue Jan 9, 2024 · 1 comment · Fixed by #296
Closed

Add full provenance info to metadata.tsv files #251

maxsibilla opened this issue Jan 9, 2024 · 1 comment · Fixed by #296
Assignees

Comments

@maxsibilla
Copy link
Contributor

Jonathan has requested that the full provenance metadata information be included in the metadata.tsv files that are currently being generated (which only include the actual data metadata that we obtain during dataset ingest).

Both for the endpoint that will generate a metadata.tsv file for a dataset and a publication time change the contents of the metadata.tsv file to include the full json response of the entity-api /entities/<dataset id> endpoint and add to that lists of the full response all associated donors, organs and samples. See example cypher below to obtain the uuids of these associated entities, then make calls to the entity-api /entities/<entity id> endpoint to get the json for inclusion in the list of each type.

Related to hubmapconsortium/ingest-api#411

@maxsibilla
Copy link
Contributor Author

@tjmadonna It looks like whenever a dataset gets published a metadata.json file gets created and that is what needs to be updated. See: https://github.com/hubmapconsortium/ingest-api/blob/b591031cdf943749f3bf858dd12f594eb5f6421a/src/app.py#L951-L960

Relevant PR where this update is made:
https://github.com/hubmapconsortium/ingest-api/pull/481/files

A companion issue is sennetconsortium/entity-api#285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants