Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: refactor extract_mel_filter_bank_from_audios #178

Closed
1 task done
satra opened this issue Nov 7, 2024 · 0 comments · Fixed by #182
Closed
1 task done

Task: refactor extract_mel_filter_bank_from_audios #178

satra opened this issue Nov 7, 2024 · 0 comments · Fixed by #182
Assignees
Labels
enhancement New feature or request

Comments

@satra
Copy link
Collaborator

satra commented Nov 7, 2024

Description

the current extract_mel_filter_bank_from_audios extraction (

def extract_mel_filter_bank_from_audios(
) extracts spectrograms for all audios. it would be nice to have that as an optional input in case they have been already generated or broken into separate functions.

Tasks

  • refactor mfcc function to take optional input or break into two functions, one from audios and one from spectrograms

Freeform Notes

more generally consider optimizing internal parallelization so that scale of number of files doesn't can be handled with limited memory. (this may apply to multiple functions).

@fabiocat93 fabiocat93 linked a pull request Nov 13, 2024 that will close this issue
@fabiocat93 fabiocat93 self-assigned this Nov 14, 2024
@fabiocat93 fabiocat93 added the enhancement New feature or request label Nov 14, 2024
@fabiocat93 fabiocat93 moved this to In review in senselab Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in senselab Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants