-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add frame drop issue generation #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regex-on-main-thread
…t/feat/27-image-on-main
…ides for debug mode and swizzling; set a scope tag for swizzling
I was just waiting to see if i could investigate a possible bug in the sdk related to frame drop issues but that shouldn't hold this up any more, I'd say this is ready to go. |
armcknight
force-pushed
the
armcknight/feat/64-frame-drop-issue
branch
from
November 7, 2023 19:12
1e20c85
to
9358c8d
Compare
realkosty
approved these changes
Nov 8, 2023
I reverted the change to CODEOWNERS and put it in a separate PR: #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
adds a couple other quality of life improvements:
launch args: