Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frame drop issue generation #65

Merged
merged 22 commits into from
Nov 19, 2023

Conversation

armcknight
Copy link
Collaborator

@armcknight armcknight commented Oct 18, 2023

Closes #64

adds a couple other quality of life improvements:

  • remove cocoapods and bring in Sentry with SPM (removes lots of files, including the Sentry.xcworkspace). you can right click on the packages and select "Update..." to upgrade them:
    image

launch args:

  • debug logging overrides via launch args, in both directions, depending on whether it's a debug build (default to debug mode on, with an override option to disable) or release (vice versa)
  • add launch arg option to disable SDK swizzling, and set a tag on the scope indicating whether it's enabled or not (helps if trying to figure out interactions with various parts of the automatic instrumentation, or just turn them off for something)
    image

@armcknight
Copy link
Collaborator Author

I was just waiting to see if i could investigate a possible bug in the sdk related to frame drop issues but that shouldn't hold this up any more, I'd say this is ready to go.

@armcknight armcknight marked this pull request as ready for review October 20, 2023 23:04
@armcknight armcknight force-pushed the armcknight/feat/64-frame-drop-issue branch from 1e20c85 to 9358c8d Compare November 7, 2023 19:12
@armcknight
Copy link
Collaborator Author

armcknight commented Nov 16, 2023

I reverted the change to CODEOWNERS and put it in a separate PR: #66

@kpujjigit
Copy link
Contributor

Flagship Error Symbolicated:
image

Flagship Transaction as expected:
image

Changes Verified.

@kpujjigit kpujjigit merged commit 652ccd7 into master Nov 19, 2023
2 of 3 checks passed
@kpujjigit kpujjigit deleted the armcknight/feat/64-frame-drop-issue branch November 19, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulate a "Frame Drop" profiling issue
3 participants