generated from sentrysoftware/oss-maven-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4: Develop Connector Reference Report Goal #11
Merged
NassimBtk
merged 5 commits into
main
from
feature/4-develop-connector-reference-report-goal
Jan 4, 2024
Merged
Issue #4: Develop Connector Reference Report Goal #11
NassimBtk
merged 5 commits into
main
from
feature/4-develop-connector-reference-report-goal
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Developed ReferenceReport that defines the `metricshub-connector-reference` Mojo. * Developed ConnectorLibraryParser to read and parse the connectors. * Developed ConnectorPageReferenceProducer to produce the connector page. * Developed MainPageReferenceProducer to produce the main connector page. * Developed PlatformReport that defines the `metricshub-connector-platforms` Mojo. * Developed unit tests and ITs.
NassimBtk
added
good first issue
Good for newcomers
java
Pull requests that update Java code
labels
Jan 2, 2024
* Fixed repository URL in POM.
* Removed MIB2Solaris from integration tests.
bertysentry
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! A few comments, nothing important.
src/main/java/org/sentrysoftware/maven/metricshub/connector/Constants.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/maven/metricshub/connector/parser/AbstractNodeProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/maven/metricshub/connector/parser/AbstractNodeProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/maven/metricshub/connector/parser/AbstractNodeProcessor.java
Outdated
Show resolved
Hide resolved
...n/java/org/sentrysoftware/maven/metricshub/connector/producer/MainPageReferenceProducer.java
Outdated
Show resolved
Hide resolved
...main/java/org/sentrysoftware/maven/metricshub/connector/producer/PlatformReportProducer.java
Show resolved
Hide resolved
...java/org/sentrysoftware/maven/metricshub/connector/producer/model/common/TechnologyType.java
Outdated
Show resolved
Hide resolved
Incorporated feedback from review: * Enhanced plugins configuration in POM. * Fixed issues in Java code and Javadoc. * Added site.css in integration tests for illustration.
Incorporated feedback from review: * Fixed `Connectors Directory`head and title.
bertysentry
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
NassimBtk
deleted the
feature/4-develop-connector-reference-report-goal
branch
January 4, 2024 12:44
NassimBtk
changed the title
[#4] Develop Connector Reference Report Goal
Issue #4: Develop Connector Reference Report Goal
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metricshub-connector-reference
Mojo.metricshub-connector-platforms
Mojo.