Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4: Develop Connector Reference Report Goal #11

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

NassimBtk
Copy link
Member

  • Developed ReferenceReport that defines the metricshub-connector-reference Mojo.
  • Developed ConnectorLibraryParser to read and parse the connectors.
  • Developed ConnectorPageReferenceProducer to produce the connector page.
  • Developed MainPageReferenceProducer to produce the main connector page.
  • Developed PlatformReport that defines the metricshub-connector-platforms Mojo.
  • Developed unit tests and ITs.

* Developed ReferenceReport that defines the
`metricshub-connector-reference` Mojo.
* Developed ConnectorLibraryParser to read and parse the connectors.
* Developed ConnectorPageReferenceProducer to produce the connector
page.
* Developed MainPageReferenceProducer to produce the main connector
page.
* Developed PlatformReport that defines the
`metricshub-connector-platforms` Mojo.
* Developed unit tests and ITs.
@NassimBtk NassimBtk added good first issue Good for newcomers java Pull requests that update Java code labels Jan 2, 2024
@NassimBtk NassimBtk requested a review from bertysentry January 2, 2024 18:38
@NassimBtk NassimBtk self-assigned this Jan 2, 2024
@NassimBtk NassimBtk linked an issue Jan 2, 2024 that may be closed by this pull request
* Fixed repository URL in POM.
* Removed MIB2Solaris from integration tests.
Copy link
Member

@bertysentry bertysentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A few comments, nothing important.

Incorporated feedback from review:

* Enhanced plugins configuration in POM.
* Fixed issues in Java code and Javadoc.
* Added site.css in integration tests for illustration.
@NassimBtk NassimBtk requested a review from bertysentry January 4, 2024 09:36
Incorporated feedback from review:

* Fixed `Connectors Directory`head and title.
Copy link
Member

@bertysentry bertysentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@NassimBtk NassimBtk merged commit d8e3c66 into main Jan 4, 2024
1 check passed
@NassimBtk NassimBtk deleted the feature/4-develop-connector-reference-report-goal branch January 4, 2024 12:44
@NassimBtk NassimBtk changed the title [#4] Develop Connector Reference Report Goal Issue #4: Develop Connector Reference Report Goal Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop Connector Reference Report Goal
2 participants