Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #58: Add community connector GitHub link on each connector page #62

Conversation

CherfaElyes
Copy link
Contributor

  • Added community connectors github link.
  • Tested on the metricshub-doc & metricshub-enterprise doc. (on both windows & linux).

Tests

  • On a community connector
    image

  • On an enterprise connector, the link won't be generated.

* Added community connectors github link.
* Tested on the metricshub-doc & metricshub-enterprise doc.
@CherfaElyes CherfaElyes linked an issue Oct 2, 2024 that may be closed by this pull request
* Removed `public` modifier from the `ConnectorLibraryParser` constructor.
@NassimBtk NassimBtk changed the title Feature/issue 58 add community connector GitHub link on each connector page Issue #58: add community connector GitHub link on each connector page Oct 2, 2024
@bertysentry
Copy link
Member

While you're there, you could also list the tags of the connector, around the same place ;-)

* Added tags on each connector page.
* Tested the update on Metricshub community & Enterprise documentations.
@CherfaElyes
Copy link
Contributor Author

@bertysentry @NassimBtk here is the new interface after adding tags & source 😄
image

@NassimBtk NassimBtk merged commit 9958044 into main Oct 3, 2024
4 checks passed
@NassimBtk NassimBtk deleted the feature/issue-58-add-community-connector-github-link-on-each-connector-page branch October 3, 2024 10:07
@NassimBtk NassimBtk changed the title Issue #58: add community connector GitHub link on each connector page Issue #58: Add community connector GitHub link on each connector page Oct 18, 2024
@CherfaElyes CherfaElyes self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Community Connector GitHub link on each connector page
3 participants