Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When upgrading from previous version, it must be ensured that older extensions are removed #574

Closed
bertysentry opened this issue Feb 7, 2025 · 5 comments · Fixed by #602
Assignees

Comments

@bertysentry
Copy link
Member

Problem

When upgrading "in place", the new install does not remove older extensions. When the product initializes, the older extensions are loaded first, which prevents the product from working at all.

Specification

Either implement a mechanism to load only extensions marked with the proper version number, or make sure the upgrade removes older files. For Community Edition, at least document the fact that older extensions must be deleted on upgrade.

@NassimBtk
Copy link
Member

While trying to upgrade MetricsHub EE from 1.0.02 to the latest 1.1.00, we are unable to reproduce this issue. The entire MetricsHub directory is emptied and then repopulated with the new assets from the latest version.

Regarding the httpcli issue, it is a real problem that needs to be fixed:

C:\Program Files\MetricsHub>httpcli --method get --url https://dev-01:443/users
IllegalStateException: Failed to execute HTTP get query.

  NullPointerException: Cannot read the array length because "<parameter1>" is null

@NassimBtk
Copy link
Member

NassimBtk commented Feb 7, 2025

@NassimBtk
Copy link
Member

NassimBtk commented Feb 7, 2025

Re-opened #572
I will keep this issue open until we fully understand the actual use case, as we are currently unable to reproduce it.

@CherfaElyes
Copy link
Contributor

@bertysentry After testing on my Windows 11 laptop, the upgrade (using the .msi file) deletes all the C:\Program Files\MetricsHub content before re-installing the new MetricsHub version 🤷‍♂️

@bertysentry
Copy link
Member Author

bertysentry commented Feb 11, 2025 via email

CherfaElyes added a commit that referenced this issue Feb 18, 2025
* Removed versions on metricshub extensions to avoid problems when unzipping a new metricshub version on the same metricshub directory where an old version is unzipped.
* Tested on MetricsHub windows and linux.
@CherfaElyes CherfaElyes linked a pull request Feb 18, 2025 that will close this issue
NassimBtk added a commit that referenced this issue Feb 18, 2025
…grading-from-previous-version-it-must-be-ensured-that-older-extensions-are-removed

Issue #574: When upgrading from previous version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants