Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC server configuration options #106

Open
docktermj opened this issue May 24, 2023 · 0 comments
Open

Support gRPC server configuration options #106

docktermj opened this issue May 24, 2023 · 0 comments
Assignees
Labels
go Pull requests that update Go code V4 To be delivered in V4

Comments

@docktermj
Copy link
Contributor

docktermj commented May 24, 2023

Currently, no options are available for the gRPC server.

https://github.com/Senzing/serve-grpc/blob/26bd70eb20182b55a61b7c51ff03668d946312b1/grpcserver/grpcserver.go#L279

grpc.NewServer(...) does support ServerOptions.

Code similar to:

// Create generated server options.

serverOptions := []senzinghttpapi.ServerOption{
	grpc.ConnectionTimeout(600),
}

if someBool {
	serverOptions = append(serverOptions, grpc.HeaderTableSize(1024))
}

// Create server.

aGrpcServer := grpc.NewServer(serverOptions...)

Should be added to support multiple configurations of gRPC server.

Another approach is seen at:

ServerOptions []grpc.ServerOption

is part of the struct and is populated by the caller.

@github-actions github-actions bot added the triage Need to triage label May 24, 2023
@docktermj docktermj removed the triage Need to triage label May 24, 2023
@docktermj docktermj self-assigned this May 24, 2023
@docktermj docktermj added V4 To be delivered in V4 go Pull requests that update Go code labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code V4 To be delivered in V4
Projects
None yet
Development

No branches or pull requests

1 participant