feat(macro): add group macro #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the poise::group macro, which lets you group commands in a struct. Use `MyStruct::commands()` to get a vec of the commands.
GnomedDev
requested changes
May 16, 2024
Removes a redundant use std::vec;
Moves the body of group into a separate function and removes match in favour of ?
More direct comparison, without iter, map and format!.
Used a match over iterator items. Will now correctly handle paths with more than 2 segments.
GnomedDev
requested changes
May 16, 2024
Instead of quote!(), use proc_macro2::TokenStream::new()
Gives better name to command. Adds necessary use's.
GnomedDev
reviewed
Jun 14, 2024
Removes hardcoded guild id and registers commands globally. I had copied some test code and left that in.
GnomedDev
requested changes
Nov 20, 2024
|
|
||
| let group_args = <command::GroupArgs as darling::FromMeta>::from_list(&args)?; | ||
|
|
||
| // let item_impl = syn::parse_macro_input!(input_item as syn::ItemImpl); |
There was a problem hiding this comment.
Suggested change
| // let item_impl = syn::parse_macro_input!(input_item as syn::ItemImpl); |
|
|
||
| if ctx_type_with_static.is_none() { | ||
| let context_type = match function.sig.inputs.first() { | ||
| Some(syn::FnArg::Typed(syn::PatType { ty, .. })) => Some(&**ty), |
There was a problem hiding this comment.
Why return Some here just to unwrap it, there isn't a branch that returns None?
| #item_stream | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Handle ctx_type_with_static being none here?
| Ok(()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can your add a test for multiple commands, and a test for no commands in a group?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the poise::group macro, which lets you group commands in a struct.
Use
MyStruct::commands()to get a vec of the commands.See the doc of poise::group for more details.
Needs more documentation and examples.