Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add share() in Publishers extension #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add share() in Publishers extension #22

wants to merge 1 commit into from

Conversation

erikolsson
Copy link

fixes an issue where multiple subscriptions would kick off feedbacks multiple times

@erikolsson erikolsson requested a review from sergdort February 10, 2020 15:06
sergdort
sergdort requested changes Feb 10, 2020
View reviewed changes
Copy link
Owner

@sergdort sergdort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of behaviours should be applied by the consumer, because it's perfectly normal for a system to start every time new subscriber arrives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergdort sergdort sergdort requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikolsson @sergdort