Convert this package into a pure metapackage, so that UseSerilogRequestLogging() can be made available without any other dependencies

[mike-schenk]

serilog-aspnetcore/src/Serilog.AspNetCore/Serilog.AspNetCore.csproj

Line 31 in 76f4a51

<PackageReference Include="Serilog.Sinks.File" Version="4.1.0" />

There is no code in the project that depends on the Serilog.Sinks.File package.

This causes the resulting Serilog.AspNetCore NuGet package to carry along an unnecessary dependency.

[nblumhardt]

Thanks for the note, Mike.

This package was originally a metapackage with no substantial code of its own; we might consider a refactor now that there's more implementation here, but there's a usability trade-off: even the primary overloads of UseSerilog() and ReadFrom.Configuration() come from other packages and aren't directly relied upon by the code in this package.

I'd be inclined to leave this for now, but extracting RequestLoggingMiddleware into a package of its own (e.g. Serilog.AspNetCore.Http) would also seem to be a reasonable path to consuming the functionality pulled in here in a more selective manner 🤔

[sungam3r]

Relates to #127

[GraemeF]

This is starting to cause problems - the unnecessary dependencies are becoming outdated which can lead to version downgrade errors when building (especially when targeting linux, it seems), and the workaround is to add direct dependencies to the later versions of these implicitly-included packages from our projects. Feels very wrong, as our projects don't use these packages at all! 😄

[sungam3r]

#127 (comment)

[nblumhardt]

@GraemeF thanks for dropping by!

Still open to extracting the middleware/other implementation code from this package, to allow consumption of the bundled parts. Is anyone keen to analyze what would actually get moved/propose some package names for it to move into?

[sungam3r]

In #127 I proposed to remove 5 packages. Just remove, without making any new meta-packages. Any who needs specific sinks may just drop in sink package into project, that's all.

[nblumhardt]

I'm not keen on dropping the dependencies here, not least because of the downstream breakage, but also because this creates one more barrier to adopting Serilog: the default .NET web SDK includes the console logger provider for MEL, there's no extra step to install it; the default .NET web SDK enables JSON config support ... etc. etc.

Apart from the logging middleware in this package, everything else is already in fine-grained packages. If we extract the logging middleware to its own package, referenced from this one, then it's easy to just install Hosting, Configuration, the middleware package, and whatever other sinks you require. Let's push this one forward :-)