Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry specification for thread attributes is different #25

Open
theperm opened this issue Dec 10, 2024 · 2 comments
Open

Opentelemetry specification for thread attributes is different #25

theperm opened this issue Dec 10, 2024 · 2 comments

Comments

@theperm
Copy link

theperm commented Dec 10, 2024

Since this was created probably long before otel defined attributes this serilog enricher does not align with otel spec:

https://opentelemetry.io/docs/specs/semconv/attributes-registry/thread/

Could we align it or does it need a new enricher?

@Numpsy
Copy link
Member

Numpsy commented Dec 10, 2024

I think just changing the property names for the existing enrichers would be a breaking change for existing consumers?

@theperm
Copy link
Author

theperm commented Dec 12, 2024

I suspect so.. Do you think it would be better to have a new OTEL compliant version of the lib Serilog.Enrichers.OpenTelemetry.Thread? Samerepo or new repo?

Same would apply to the other libs - the Serilog.Enrichers.Process and Serilog.Enrichers.Environment

Or control with a FLAG or Env var?
I guess you could just Abstract it behind configuration in the same lib,, and have new extension methods to enable WithOpenTelemetryThreadID
or
WithThreadId(OpenTelemtrySpec=true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants