Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I13 display plot warnings #14

Merged
merged 4 commits into from
Sep 17, 2024
Merged

I13 display plot warnings #14

merged 4 commits into from
Sep 17, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Sep 17, 2024

  • don't attempt to render facets for null factor levels
  • display facet errors in place of empty plots
  • display trace warnings below facets

Closes #13

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (8c76677) to head (b5ed723).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   97.86%   98.61%   +0.74%     
==========================================
  Files          21       23       +2     
  Lines         468      504      +36     
  Branches       89      103      +14     
==========================================
+ Hits          458      497      +39     
+ Misses         10        7       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex marked this pull request as ready for review September 17, 2024 11:25
@hillalex hillalex merged commit f102021 into main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display warnings
1 participant