Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support date columns #6

Merged
merged 10 commits into from
Sep 16, 2024
Merged

support date columns #6

merged 10 commits into from
Sep 16, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Sep 15, 2024

Support x column values in date as well as numeric format. Try to parse as numbers; if that fails, parse as dates; if that fails, return a 400.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (2e7d650) to head (a6096dd).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   91.93%   92.67%   +0.73%     
==========================================
  Files           4        4              
  Lines         248      273      +25     
==========================================
+ Hits          228      253      +25     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex marked this pull request as ready for review September 16, 2024 09:49
@hillalex hillalex merged commit 12b55a9 into main Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant