[DMS-41] Fix locations for while loop invariants #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoPavel
approved these changes
Jun 14, 2024
DK318
force-pushed
the
motoko-san/while-loop-invariants-locations-fix
branch
from
59094dd to
4c1d28a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an error occurs in the loop invariant the whole while loop would be highlighted.
Solution
This issue was fixed by adding an invariant to the source mapper (adding its location to
marksarray + surrounding the format string with\017and\019) and assigning the correct location to the invariant itself.Fixed Result