Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBS on riscv64 #74

Closed
Civil opened this issue Apr 30, 2021 · 0 comments · Fixed by #75
Closed

FTBS on riscv64 #74

Civil opened this issue Apr 30, 2021 · 0 comments · Fixed by #75

Comments

@Civil
Copy link
Contributor

Civil commented Apr 30, 2021

syscall_dup.go:11:9: undefined: syscall.Dup2

Problem is the same as with arm64 - new platforms do not have syscall.Dup2, but have syscall.Dup3 instead.

Proper solution would be to get a list of all platforms that have Dup2 syscall and whitelist them for old one and use new one for all other platforms (as new platforms will likely implement Dup3 syscall and not Dup2).

Or at least to:

  1. Rename syscall_dup_arm64.go to not include arch name
  2. Build it on:
// +build linux
// +build arm64 riscv64
  1. Do not build old file on riscv64 (simple header modification).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant