Skip to content

Commit

Permalink
Removed requirement of access key and secret key
Browse files Browse the repository at this point in the history
Access key and Secret key needed to be defined in the pom file and when
they were not the pom file would not run. Since the access key and
secret key can be optional I have defined it as optional.

Fixes Upplication#3
  • Loading branch information
sfontes committed Oct 30, 2018
1 parent adccf1a commit e67c05f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<groupId>com.upplication.maven.plugins</groupId>
<artifactId>s3-download-maven-plugin</artifactId>
<version>1.0.3-SNAPSHOT</version>
<version>1.0.4-SNAPSHOT</version>
<packaging>maven-plugin</packaging>

<name>S3 download maven plugin</name>
Expand Down
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Configuration parameters
|bucketName|The name of the bucket|*yes*| |
|source|The source amazon s3 file key. Empty to download the whole bucket.|*no*| |
|destination|The destination file or destination folder. Directories *MUST* end with */*| *yes*| |
|accessKey|S3 access key | *yes* | if unspecified, uses the Default Provider, falling back to env variables |
|secretKey|S3 secret key | *yes* | if unspecified, uses the Default Provider, falling back to env variables |
|accessKey|S3 access key | *no* | if unspecified, uses the Default Provider, falling back to env variables |
|secretKey|S3 secret key | *no* | if unspecified, uses the Default Provider, falling back to env variables |
|endpoint|Use a different s3 endpoint| *no* | s3.amazonaws.com |

Example: Download a bucket
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ public class S3DownloadMojo extends AbstractMojo {
/**
* Access key for S3.
*/
@Parameter(property = "s3-download.accessKey", required = true)
@Parameter(property = "s3-download.accessKey")
private String accessKey;

/**
* Secret key for S3.
*/
@Parameter(property = "s3-download.secretKey", required = true)
@Parameter(property = "s3-download.secretKey")
private String secretKey;

/**
Expand Down

0 comments on commit e67c05f

Please sign in to comment.