Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move region index creation from vcztools #290

Open
tomwhite opened this issue Nov 26, 2024 · 1 comment
Open

Move region index creation from vcztools #290

tomwhite opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tomwhite
Copy link
Contributor

tomwhite commented Nov 26, 2024

We should remove the vcztools index command and have bio2zarr create region indexes instead. (Region indexes are used by vcztools to do efficient region queries.) Then bio2zarr would be concerned only with writing vcz and vcztools only with reading vcz.

This was suggested before (sgkit-dev/vcztools#37 (comment)), but it would be good to move it out of vcztools now before releasing it.

Should index creation be a part of vcf2zarr encode?

@tomwhite tomwhite added the enhancement New feature or request label Nov 26, 2024
@jeromekelleher
Copy link
Contributor

Should index creation be a part of vcf2zarr encode

I think that's the simplest approach all right. It's a very simple operation and we can think about how to make it more generally accessible later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants