Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Standardize missing value sentinels for string arrays #16

Open
eric-czech opened this issue Aug 4, 2020 · 0 comments
Open

Standardize missing value sentinels for string arrays #16

eric-czech opened this issue Aug 4, 2020 · 0 comments

Comments

@eric-czech
Copy link
Collaborator

Before switching to fixed length string dtypes for sample/variant metadata, None was an appropriate sentinel for missing values. This won't work for fixed length types though so read_plink should use empty strings instead (the None values are currently being coerced to "None").

I would rather not alter the values in the PLINK fam/bim files at all, but string "0" as a missing value sentinel won't be a convention we use anywhere else in sgkit, so it is worth coercing these to empty strings so users can expect a uniform representation for missing values in all string arrays.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant