You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Before switching to fixed length string dtypes for sample/variant metadata, None was an appropriate sentinel for missing values. This won't work for fixed length types though so read_plink should use empty strings instead (the None values are currently being coerced to "None").
I would rather not alter the values in the PLINK fam/bim files at all, but string "0" as a missing value sentinel won't be a convention we use anywhere else in sgkit, so it is worth coercing these to empty strings so users can expect a uniform representation for missing values in all string arrays.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Before switching to fixed length string dtypes for sample/variant metadata, None was an appropriate sentinel for missing values. This won't work for fixed length types though so
read_plink
should use empty strings instead (the None values are currently being coerced to "None").I would rather not alter the values in the PLINK
fam
/bim
files at all, but string "0" as a missing value sentinel won't be a convention we use anywhere else in sgkit, so it is worth coercing these to empty strings so users can expect a uniform representation for missing values in all string arrays.The text was updated successfully, but these errors were encountered: