Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Support fancy and scalar indexing #31

Open
eric-czech opened this issue Aug 24, 2020 · 0 comments
Open

Support fancy and scalar indexing #31

eric-czech opened this issue Aug 24, 2020 · 0 comments

Comments

@eric-czech
Copy link
Collaborator

Much like sgkit-dev/sgkit-bgen#15, this reader should break if you try to index with scalars (ds.call_genotype[0, 0]) or lists. More problematic is the fact that Dask will request slices as scalar indices if a variant/sample chunk only has one item. Adding fancy=False to from_array, converting int slicers to actual slices, and then squeezing off unit dimensions in the chunks read is enough to fix these problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant