Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test_count_call_alleles on Cubed #1249

Closed
wants to merge 5 commits into from

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Sep 2, 2024

See #908

@tomwhite
Copy link
Collaborator Author

tomwhite commented Sep 2, 2024

This is passing all tests, but when producing a visualization of the Dask graph I noticed that it reintroduces the problem in #871, so shouldn't be merged. (cc @timothymillar)

@tomwhite
Copy link
Collaborator Author

tomwhite commented Sep 2, 2024

In the meeting @jeromekelleher suggested that we could abstract the map_blocks bit into a function in sgkit that dispatches either to da.map_blocks (for Dask arrays) or xr.apply_ufunc (for everything else, including Cubed). This would keep the Dask path as it is today, while allowing other array libraries to work.

Copy link
Contributor

mergify bot commented Sep 10, 2024

This PR has conflicts, @tomwhite please rebase and push updated version 🙏

@mergify mergify bot added the conflict PR conflict label Sep 10, 2024
@tomwhite
Copy link
Collaborator Author

Superseded by #1254

@tomwhite tomwhite closed this Sep 10, 2024
@mergify mergify bot removed the conflict PR conflict label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant