New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify type of `vcf_zarr_version` attr #16

Open

jeromekelleher opened this issue Feb 26, 2024 · 2 comments

Contributor

jeromekelleher commented Feb 26, 2024

I'm assuming it's a string, but it could be interpreted as a float

Collaborator

tomwhite commented Feb 26, 2024

Yes, it's a string. In general versions are not floats (e.g. 0.2.1).

Contributor Author

jeromekelleher commented Feb 26, 2024

I think we just need to put some quotes around the value to make that more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment