Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Regex stop condition #2007

Open
2 tasks done
SinanAkkoyun opened this issue Nov 11, 2024 · 1 comment
Open
2 tasks done

[Feature] Regex stop condition #2007

SinanAkkoyun opened this issue Nov 11, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@SinanAkkoyun
Copy link

SinanAkkoyun commented Nov 11, 2024

Checklist

Motivation

Hi! This would be awesome, as it would address following problems:

  • most custom stopping conditions can be expressed as a regex
  • handling custom stopping in a streaming response does not work as quickly as a backend based stopping condition would

(at least in my testing, a NodeJS client (with breaking the AsyncGenerator for await loop) can not stop the SGLang streaming generation the same way it works with the official OpenAI API)

I hope this is easy to implement

Related resources

No response

@merrymercy merrymercy added the good first issue Good for newcomers label Nov 14, 2024
@merrymercy
Copy link
Contributor

Contribution is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants