Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariani should limit characters that can be typed as a user symbol #38

Open
sh95014 opened this issue Jun 4, 2023 · 3 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sh95014
Copy link
Owner

sh95014 commented Jun 4, 2023

@Michaelangel007 would you happen to know what characters are allowed, and how many? The character limit seems to be 8 but I’m have a hard time working out what characters are legal.

(Right now the user can type whatever and SYM just fails to create it.)

@sh95014 sh95014 added the question Further information is requested label Jun 4, 2023
@Michaelangel007
Copy link

Michaelangel007 commented Jun 4, 2023

What is Mariani? Ah, the name of your build of AppleWin.

Unfortunately I never nailed down a spec for what are valid characters for symbols. Most non operators may (should?) be allowed due to some assembler using ] as a valid local symbol.

The file Debugger_Types.h defines MAX_SYMBOLS_LEN = 31 which is the hard-limit. This is needed due to some of Bob Sander-Cederlof's Applesoft symbols.

There is a soft limit or a DISASM_DISPLAY_MAX_TARGET_LEN. See the func: ParseSymbolTable() in Debugger_Symbols.cpp which warns about long symbols names if you are running a DEBUG build of AppleWin.

@sh95014
Copy link
Owner Author

sh95014 commented Jun 4, 2023

Sorry, Mariani is what I call AppleWin for macOS because AppleWin for macOS sounds just a bit silly. :)

Thanks!

@Michaelangel007
Copy link

There are some of the long names:

debugger_wan_long_symbol_names

debugger_wan_long_symbol_names2

@sh95014 sh95014 added good first issue Good for newcomers enhancement New feature or request and removed question Further information is requested labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants