Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: code ui updated for light mode and scrollbar added for all browsers || opengraph warning fixed #1721

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: code ui updated for light mode and scrollbar added for all browsers || opengraph warning fixed #1721

wants to merge 7 commits into from

Conversation

beingofexistence13
Copy link

@beingofexistence13 beingofexistence13 commented Oct 11, 2023 •
edited
Loading

hello!!!
in my code I have:

  1. fixed opengraph wanring which was occuring for not using metadataBase in metadata apps/www/app/layout.tsx
  2. fixed the code button was not using any light colors in light mode at apps/www/styles/global.css
  3. scrollbar added for chrome,firefox,edge,brave

@vercel
Copy link

vercel bot commented Oct 11, 2023

@beingofexistence is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@beingofexistence13
Copy link
Author

please review changes for once.
I am pretty sure that you will like it!!!

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 1:34pm

shadcn
shadcn requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beingofexistence I left a few comments.

apps/www/package.json Outdated Show resolved Hide resolved
apps/www/package.json Outdated Show resolved Hide resolved
apps/www/styles/globals.css Outdated Show resolved Hide resolved
apps/www/styles/globals.css Outdated Show resolved Hide resolved
@shadcn shadcn added the postpone: more info or changes requested maintainers asked a question or needs more info label Oct 21, 2023
@beingofexistence13
Copy link
Author

new_recording_-_10_24_2023,_1_41_26_pm (Original)

Sorry, for late response.
I checked the code as you guided me and also merged my old branch to current shadcn/ui main branch.
So, please review the code last time!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadcn shadcn Awaiting requested review from shadcn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
postpone: more info or changes requested maintainers asked a question or needs more info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beingofexistence13 @shadcn